lakshmi-manasa-g commented on PR #1631: URL: https://github.com/apache/samza/pull/1631#issuecomment-1258231304
> In terms of the assumption on diagnostics stream is stream with one partition count, can that be created explicitly by the user? Or potentially expanded to more than one partition? >In that case, it could still mean a incompatible change right? the default creation for diag stream inside samza framework code is with 1 partition. that said, i think it can be expanded to more than 1 partition. Maybe if the stream is pre-created before the job creates it then it can be created with >1 as well. Yes, if the diag stream has >1 partition prior to upgrading to this PR, then it could be an incompatible change. thanks for catching this. @jia-gao can you please mark this PR as backwards incompatible along with an explanation as to WHEN it is backwards incompatible. without the when part, this might be seen as a breaking change in all cases which it is not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
