[
https://issues.apache.org/jira/browse/SAMZA-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027021#comment-14027021
]
Martin Kleppmann commented on SAMZA-20:
---------------------------------------
The parsing of the Java version number seems quite fragile. Not sure if
non-Hotspot JVMs will match the output of $(java -version) closely enough for
this to work.
Do you have access to an older/non-Hotspot JVM to test it? It would be nicest
if we could simply always set the option (if we are confident that older JVMs
will ignore it, not fail).
Also, have you tested whether the GC rolling actually works? In your patch it
looks like you're missing a space between two of the options.
> Roll gc logs in run-class.sh
> ----------------------------
>
> Key: SAMZA-20
> URL: https://issues.apache.org/jira/browse/SAMZA-20
> Project: Samza
> Issue Type: Bug
> Components: container
> Affects Versions: 0.6.0
> Reporter: Chris Riccomini
> Assignee: Raul Castro Fernandez
> Labels: newbie
> Attachments: samza-20.patch
>
>
> The run-class.sh script defaults to setting up a gc.log file, if SAMZA_OPTS
> is undefined.
> Newer versions of Java 6, and Java 7 allow you to roll gc log files with
> -XX:+UseGCLogFileRotation. See
> http://stackoverflow.com/questions/3822097/rolling-garbage-collector-logs-in-java
> for details.
> Should also validate that the change doesn't break with older Java 6 versions.
> Also, [~sureshms] was saying that there's an alternate way to do this. Suresh
> - care to chime in?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
