[
https://issues.apache.org/jira/browse/SAMZA-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028247#comment-14028247
]
Chris Riccomini commented on SAMZA-20:
--------------------------------------
Cool. Only other nit is rather than duplicating this chunk of parameters twice:
{noformat}
JAVA_OPTS="-Xmx768M -XX:+PrintGCDateStamps -Xloggc:$SAMZA_LOG_DIR/gc.log
-Dsamza.log.dir=$SAMZA_LOG_DIR -Dsamza.container.name=$SAMZA_CONTAINER_NAME"
{noformat}
Can we just set it once, and then have the if/fi statement append the file
rotation stuff? Seems a little cleaner.
> Roll gc logs in run-class.sh
> ----------------------------
>
> Key: SAMZA-20
> URL: https://issues.apache.org/jira/browse/SAMZA-20
> Project: Samza
> Issue Type: Bug
> Components: container
> Affects Versions: 0.6.0
> Reporter: Chris Riccomini
> Assignee: Raul Castro Fernandez
> Labels: newbie
> Attachments: samza-20.patch
>
>
> The run-class.sh script defaults to setting up a gc.log file, if SAMZA_OPTS
> is undefined.
> Newer versions of Java 6, and Java 7 allow you to roll gc log files with
> -XX:+UseGCLogFileRotation. See
> http://stackoverflow.com/questions/3822097/rolling-garbage-collector-logs-in-java
> for details.
> Should also validate that the change doesn't break with older Java 6 versions.
> Also, [~sureshms] was saying that there's an alternate way to do this. Suresh
> - care to chime in?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
