[ 
https://issues.apache.org/jira/browse/SAMZA-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028370#comment-14028370
 ] 

Chris Riccomini commented on SAMZA-20:
--------------------------------------

I think we don't need the GC_LOG_OUTPUT variable. We had 
-Xloggc:$SAMZA_LOG_DIR/gc.log in JAVA_OPTS before, and I think we need it 
regardless of whether we roll or not. COMMON_PARAMS seems like the right spot 
for it.

> Roll gc logs in run-class.sh
> ----------------------------
>
>                 Key: SAMZA-20
>                 URL: https://issues.apache.org/jira/browse/SAMZA-20
>             Project: Samza
>          Issue Type: Bug
>          Components: container
>    Affects Versions: 0.6.0
>            Reporter: Chris Riccomini
>            Assignee: Raul Castro Fernandez
>              Labels: newbie
>         Attachments: samza-20.patch
>
>
> The run-class.sh script defaults to setting up a gc.log file, if SAMZA_OPTS 
> is undefined.
> Newer versions of Java 6, and Java 7 allow you to roll gc log files with 
> -XX:+UseGCLogFileRotation. See 
> http://stackoverflow.com/questions/3822097/rolling-garbage-collector-logs-in-java
>  for details.
> Should also validate that the change doesn't break with older Java 6 versions.
> Also, [~sureshms] was saying that there's an alternate way to do this. Suresh 
> - care to chime in?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to