TyrantLucifer commented on a change in pull request #1188:
URL:
https://github.com/apache/incubator-seatunnel/pull/1188#discussion_r800182317
##########
File path:
seatunnel-apis/seatunnel-api-spark/src/main/java/org/apache/seatunnel/spark/batch/SparkBatchSink.java
##########
@@ -14,12 +14,17 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.seatunnel.spark.batch
-import org.apache.seatunnel.spark.BaseSparkSink
+package org.apache.seatunnel.spark.batch;
+
+import org.apache.seatunnel.spark.BaseSparkSink;
+
+import scala.Unit;
/**
* a SparkBatchSink plugin will write data to other system
* using Spark DataSet API.
*/
-trait SparkBatchSink extends BaseSparkSink[Unit] {}
+@SuppressWarnings("PMD.AbstractClassShouldStartWithAbstractNamingRule")
+public abstract class SparkBatchSink extends BaseSparkSink<Unit> {
Review comment:
Because of `org.apache.seatunnel.spark.sink.Kafka` is developed by
scala, so the return type of output method is Unit, if I change it to Void it
will be compiled error as below:
So I did not change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
