TyrantLucifer commented on a change in pull request #1188:
URL:
https://github.com/apache/incubator-seatunnel/pull/1188#discussion_r800183737
##########
File path:
seatunnel-apis/seatunnel-api-spark/src/main/java/org/apache/seatunnel/spark/BaseSparkSink.java
##########
@@ -14,23 +14,38 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.seatunnel.spark
-import org.apache.seatunnel.apis.BaseSink
-import org.apache.seatunnel.shade.com.typesafe.config.{Config, ConfigFactory}
-import org.apache.spark.sql.{Dataset, Row}
+package org.apache.seatunnel.spark;
+
+import org.apache.seatunnel.apis.BaseSink;
+import org.apache.seatunnel.common.config.CheckResult;
+
+import org.apache.seatunnel.shade.com.typesafe.config.Config;
+import org.apache.seatunnel.shade.com.typesafe.config.ConfigFactory;
+
+import org.apache.spark.sql.Dataset;
+import org.apache.spark.sql.Row;
/**
* a base interface indicates a sink plugin running on Spark.
*/
-trait BaseSparkSink[OUT] extends BaseSink[SparkEnvironment] {
+public abstract class BaseSparkSink<OUT> implements BaseSink<SparkEnvironment>
{
+
+ protected Config config = ConfigFactory.empty();
- protected var config: Config = ConfigFactory.empty()
+ @Override
+ public void setConfig(Config config) {
+ this.config = config;
+ }
- override def setConfig(config: Config): Unit = this.config = config
+ @Override
+ public Config getConfig() {
+ return config;
+ }
- override def getConfig: Config = config
+ public abstract CheckResult checkConfig();
Review comment:
[4d57c66](https://github.com/apache/incubator-seatunnel/pull/1188/commits/4d57c66251bd3e72f5c8f6e0748c20fab6a72a92)
had been resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
