liugddx commented on code in PR #3792:
URL: 
https://github.com/apache/incubator-seatunnel/pull/3792#discussion_r1057180911


##########
seatunnel-engine/seatunnel-engine-storage/imap-storage-api/pom.xml:
##########
@@ -31,6 +31,12 @@
     <artifactId>imap-storage-api</artifactId>
 
     <dependencies>
+        <dependency>
+            <groupId>org.apache.seatunnel</groupId>
+            <artifactId>seatunnel-api</artifactId>
+            <version>${project.version}</version>
+        </dependency>

Review Comment:
   > As a base module, I don't think we need to depend on seatunnel-api, how 
confusing it is.
   
   'IMapStorageFactory' implements' 
org.apache.seatunnel.api.table.factory.Factory', Whether we need to move the 
Factory here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to