Hisoka-X commented on code in PR #3792:
URL:
https://github.com/apache/incubator-seatunnel/pull/3792#discussion_r1059216480
##########
seatunnel-engine/seatunnel-engine-storage/imap-storage-api/pom.xml:
##########
@@ -31,6 +31,12 @@
<artifactId>imap-storage-api</artifactId>
<dependencies>
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-api</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review Comment:
Seem like can't use Factory which in `seatunnel-api`, because it need return
option rule which design for connector, Just create `IMapStorageFactory`
without implement Factory in `seatunnel-api` is fine for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
