liugddx commented on code in PR #3792:
URL:
https://github.com/apache/incubator-seatunnel/pull/3792#discussion_r1058715203
##########
seatunnel-engine/seatunnel-engine-storage/imap-storage-api/pom.xml:
##########
@@ -31,6 +31,12 @@
<artifactId>imap-storage-api</artifactId>
<dependencies>
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-api</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review Comment:
I have some doubts about this, so I think it is necessary to discuss
here.Now the SPI obtains the Factory mainly for the connector,Should we migrate
this function to `seatunnel-common` or implement a lightweight function in the
engine?
Please give me some advice, thanks!
@CalvinKirs @EricJoy2048 @ashulin @hailin0 @TyrantLucifer @Hisoka-X @ic4y .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
