liugddx commented on code in PR #4227:
URL:
https://github.com/apache/incubator-seatunnel/pull/4227#discussion_r1118467487
##########
config/jvm_options:
##########
@@ -102,4 +102,7 @@
8:-Xloggc:${loggc}
8:-XX:+UseGCLogFileRotation
8:-XX:NumberOfGCLogFiles=32
-8:-XX:GCLogFileSize=64m
\ No newline at end of file
+8:-XX:GCLogFileSize=64m
+
+-XX:+HeapDumpOnOutOfMemoryError
+-XX:HeapDumpPath=/data/whaletunnel/
Review Comment:
```suggestion
-XX:HeapDumpPath=/data/seatunnel/
```
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/source/IncrementalSource.java:
##########
@@ -134,7 +134,7 @@ public SourceReader<T, SourceSplitBase>
createReader(SourceReader.Context reader
// create source config for the given subtask (e.g. unique server id)
C sourceConfig =
configFactory.create(readerContext.getIndexOfSubtask());
BlockingQueue<RecordsWithSplitIds<SourceRecords>> elementsQueue =
- new LinkedBlockingQueue<>(1024);
+ new LinkedBlockingQueue<>(2);
Review Comment:
Why is 2
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-mysql/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mysql/utils/MySqlUtils.java:
##########
@@ -339,7 +340,12 @@ private static PreparedStatement
initStatement(JdbcConnection jdbc, String sql,
throws SQLException {
final Connection connection = jdbc.connection();
connection.setAutoCommit(false);
- final PreparedStatement statement = connection.prepareStatement(sql);
+ final PreparedStatement statement =
+ connection.prepareStatement(
+ sql, ResultSet.TYPE_FORWARD_ONLY,
ResultSet.CONCUR_READ_ONLY);
+ if (fetchSize == 0) {
+ fetchSize = 1024;
Review Comment:
```suggestion
fetchSize = Integer.MIN_VALUE;
```
##########
seatunnel-connectors-v2/connector-common/src/main/java/org/apache/seatunnel/connectors/seatunnel/common/source/reader/SourceReaderBase.java:
##########
@@ -158,7 +158,12 @@ private RecordsWithSplitIds<E> getNextFetch(Collector<T>
output) {
splitFetcherManager.checkErrors();
RecordsWithSplitIds<E> recordsWithSplitId = elementsQueue.poll();
if (recordsWithSplitId == null || !moveToNextSplit(recordsWithSplitId,
output)) {
- log.trace("Current fetch is finished.");
+ try {
+ log.trace("Current fetch is finished.");
+ Thread.sleep(100);
+ } catch (InterruptedException e) {
+ throw new RuntimeException(e);
Review Comment:
Unified exception?
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-mysql/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mysql/utils/MySqlUtils.java:
##########
@@ -339,7 +340,12 @@ private static PreparedStatement
initStatement(JdbcConnection jdbc, String sql,
throws SQLException {
final Connection connection = jdbc.connection();
connection.setAutoCommit(false);
- final PreparedStatement statement = connection.prepareStatement(sql);
+ final PreparedStatement statement =
+ connection.prepareStatement(
+ sql, ResultSet.TYPE_FORWARD_ONLY,
ResultSet.CONCUR_READ_ONLY);
+ if (fetchSize == 0) {
+ fetchSize = 1024;
Review Comment:
https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-reference-implementation-notes.html
##########
seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterFaultToleranceIT.java:
##########
@@ -810,56 +830,77 @@ public void testStreamJobRestoreInAllNodeDown()
node1.shutdown();
node2.shutdown();
+ log.info(
+ "==========================================All node is
done========================================");
Thread.sleep(10000);
node1 =
SeaTunnelServerStarter.createHazelcastInstance(seaTunnelConfig);
node2 =
SeaTunnelServerStarter.createHazelcastInstance(seaTunnelConfig);
+ System.out.println(
+ "==========================================All node is
start, begin check node size ========================================");
Review Comment:
```suggestion
log.info(
"==========================================All node is
start, begin check node size ========================================");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
