liugddx commented on code in PR #4227:
URL:
https://github.com/apache/incubator-seatunnel/pull/4227#discussion_r1118580546
##########
seatunnel-engine/seatunnel-engine-storage/checkpoint-storage-plugins/checkpoint-storage-hdfs/src/main/java/org/apache/seatunnel/engine/checkpoint/storage/hdfs/HdfsStorage.java:
##########
@@ -242,8 +243,8 @@ public PipelineState getCheckpoint(String jobId, String
pipelineId, String check
String path = getStorageParentDirectory() + jobId;
List<String> fileNames = getFileNames(path);
if (fileNames.isEmpty()) {
- throw new CheckpointStorageException(
- "No checkpoint found for job, job id is: " + jobId);
+ log.info("No checkpoint found for job, job id is: " + jobId);
Review Comment:
```suggestion
log.info("No checkpoint found for this job, the job id is: " +
jobId);
```
##########
seatunnel-engine/seatunnel-engine-storage/checkpoint-storage-plugins/checkpoint-storage-hdfs/src/main/java/org/apache/seatunnel/engine/checkpoint/storage/hdfs/HdfsStorage.java:
##########
@@ -174,7 +174,7 @@ public List<PipelineState> getLatestCheckpoint(String
jobId) throws CheckpointSt
});
if (latestPipelineStates.isEmpty()) {
- throw new CheckpointStorageException("No checkpoint found for job,
job id:{} " + jobId);
+ log.info("No checkpoint found for job, job id:{} " + jobId);
Review Comment:
```suggestion
log.info("No checkpoint found for this job, the job id:{} " +
jobId);
```
##########
seatunnel-engine/seatunnel-engine-storage/checkpoint-storage-plugins/checkpoint-storage-hdfs/src/main/java/org/apache/seatunnel/engine/checkpoint/storage/hdfs/HdfsStorage.java:
##########
@@ -135,8 +135,8 @@ public List<PipelineState> getAllCheckpoints(String jobId)
throws CheckpointStor
String path = getStorageParentDirectory() + jobId;
List<String> fileNames = getFileNames(path);
if (fileNames.isEmpty()) {
- throw new CheckpointStorageException(
- "No checkpoint found for job, job id is: " + jobId);
+ log.info("No checkpoint found for job, job id is: " + jobId);
Review Comment:
```suggestion
log.info("No checkpoint found for this job, the job id is: " +
jobId);
```
##########
seatunnel-engine/seatunnel-engine-storage/checkpoint-storage-plugins/checkpoint-storage-hdfs/src/main/java/org/apache/seatunnel/engine/checkpoint/storage/hdfs/HdfsStorage.java:
##########
@@ -159,8 +159,8 @@ public List<PipelineState> getLatestCheckpoint(String
jobId) throws CheckpointSt
String path = getStorageParentDirectory() + jobId;
List<String> fileNames = getFileNames(path);
if (fileNames.isEmpty()) {
- throw new CheckpointStorageException(
- "No checkpoint found for job, job id is: " + jobId);
+ log.info("No checkpoint found for job, job id is: " + jobId);
Review Comment:
```suggestion
log.info("No checkpoint found for this job, the job id is: " +
jobId);
```
##########
seatunnel-engine/seatunnel-engine-storage/checkpoint-storage-plugins/checkpoint-storage-hdfs/src/main/java/org/apache/seatunnel/engine/checkpoint/storage/hdfs/HdfsStorage.java:
##########
@@ -185,18 +185,19 @@ public PipelineState
getLatestCheckpointByJobIdAndPipelineId(String jobId, Strin
String path = getStorageParentDirectory() + jobId;
List<String> fileNames = getFileNames(path);
if (fileNames.isEmpty()) {
- throw new CheckpointStorageException(
- "No checkpoint found for job, job id is: " + jobId);
+ log.info("No checkpoint found for job, job id is: " + jobId);
+ return null;
}
String latestFileName =
getLatestCheckpointFileNameByJobIdAndPipelineId(fileNames,
pipelineId);
if (latestFileName == null) {
- throw new CheckpointStorageException(
+ log.info(
"No checkpoint found for job, job id is: "
Review Comment:
```suggestion
"No checkpoint found for this job, the job id is: "
```
##########
seatunnel-engine/seatunnel-engine-storage/checkpoint-storage-plugins/checkpoint-storage-hdfs/src/main/java/org/apache/seatunnel/engine/checkpoint/storage/hdfs/HdfsStorage.java:
##########
@@ -207,8 +208,8 @@ public List<PipelineState>
getCheckpointsByJobIdAndPipelineId(String jobId, Stri
String path = getStorageParentDirectory() + jobId;
List<String> fileNames = getFileNames(path);
if (fileNames.isEmpty()) {
- throw new CheckpointStorageException(
- "No checkpoint found for job, job id is: " + jobId);
+ log.info("No checkpoint found for job, job id is: " + jobId);
Review Comment:
```suggestion
log.info("No checkpoint found for this job, the job id is: " +
jobId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
