liugddx commented on code in PR #4227:
URL:
https://github.com/apache/incubator-seatunnel/pull/4227#discussion_r1118855025
##########
seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterFaultToleranceIT.java:
##########
@@ -133,6 +133,7 @@ public void testBatchJobRunOkIn2Node() throws
ExecutionException, InterruptedExc
FileUtils.getFileLineNumberFromDir(testResources.getLeft());
Assertions.assertEquals(testRowNumber * testParallelism,
fileLineNumberFromDir);
System.out.println(engineClient.getJobMetrics(clientJobProxy.getJobId()));
+ System.out.println("========================clean test
resource====================");
Review Comment:
```suggestion
log.info("========================clean test
resource====================");
```
##########
seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterFaultToleranceIT.java:
##########
@@ -345,10 +348,12 @@ public void testBatchJobRestoreIn2NodeWorkerDown()
});
// shutdown on worker node
+ System.out.println(
Review Comment:
```suggestion
log.info(
```
##########
seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterFaultToleranceIT.java:
##########
@@ -559,13 +565,18 @@ public void testBatchJobRestoreIn2NodeMasterDown()
node1.shutdown();
Awaitility.await()
- .atMost(200000, TimeUnit.MILLISECONDS)
+ .atMost(600000, TimeUnit.MILLISECONDS)
.untilAsserted(
- () ->
- Assertions.assertTrue(
- objectCompletableFuture.isDone()
- &&
JobStatus.FINISHED.equals(
-
objectCompletableFuture.get())));
+ () -> {
+ Thread.sleep(2000);
+ System.out.println(
Review Comment:
```suggestion
log.info(
```
##########
seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterFaultToleranceTwoPipelineIT.java:
##########
@@ -368,18 +367,23 @@ public void
testTwoPipelineBatchJobRestoreIn2NodeWorkerDown()
node2.shutdown();
Awaitility.await()
- .atMost(400000, TimeUnit.MILLISECONDS)
+ .atMost(600000, TimeUnit.MILLISECONDS)
.untilAsserted(
- () ->
- Assertions.assertTrue(
- objectCompletableFuture.isDone()
- &&
JobStatus.FINISHED.equals(
-
objectCompletableFuture.get())));
+ () -> {
+ // Wait some tasks commit finished
+ Thread.sleep(2000);
+ System.out.println(
Review Comment:
```suggestion
log.info(
```
##########
seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterFaultToleranceIT.java:
##########
@@ -810,56 +830,77 @@ public void testStreamJobRestoreInAllNodeDown()
node1.shutdown();
node2.shutdown();
+ log.info(
+ "==========================================All node is
done========================================");
Thread.sleep(10000);
node1 =
SeaTunnelServerStarter.createHazelcastInstance(seaTunnelConfig);
node2 =
SeaTunnelServerStarter.createHazelcastInstance(seaTunnelConfig);
+ log.info(
+ "==========================================All node is
start, begin check node size ========================================");
// waiting all node added to cluster
HazelcastInstanceImpl restoreFinalNode = node1;
Awaitility.await()
- .atMost(10000, TimeUnit.MILLISECONDS)
+ .atMost(60000, TimeUnit.MILLISECONDS)
.untilAsserted(
() ->
Assertions.assertEquals(
2,
restoreFinalNode.getCluster().getMembers().size()));
+ log.info(
+ "==========================================All node is
running========================================");
+ engineClient = new SeaTunnelClient(clientConfig);
+ ClientJobProxy newClientJobProxy =
engineClient.createJobClient().getJobProxy(jobId);
+ CompletableFuture<JobStatus> waitForJobCompleteFuture =
+
CompletableFuture.supplyAsync(newClientJobProxy::waitForJobComplete);
+
Awaitility.await()
- .atMost(360000, TimeUnit.MILLISECONDS)
+ .atMost(600000, TimeUnit.MILLISECONDS)
.untilAsserted(
() -> {
// Wait job write all rows in file
Thread.sleep(2000);
System.out.println(
Review Comment:
```suggestion
log.info(
```
##########
seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterFaultToleranceTwoPipelineIT.java:
##########
@@ -592,13 +604,19 @@ public void
testTwoPipelineBatchJobRestoreIn2NodeMasterDown()
node1.shutdown();
Awaitility.await()
- .atMost(360000, TimeUnit.MILLISECONDS)
+ .atMost(600000, TimeUnit.MILLISECONDS)
.untilAsserted(
- () ->
- Assertions.assertTrue(
- objectCompletableFuture.isDone()
- &&
JobStatus.FINISHED.equals(
-
objectCompletableFuture.get())));
+ () -> {
+ // Wait some tasks commit finished
+ Thread.sleep(2000);
+ System.out.println(
Review Comment:
```suggestion
log.info(
```
##########
seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterFaultToleranceIT.java:
##########
@@ -311,6 +312,8 @@ public void testBatchJobRestoreIn2NodeWorkerDown()
Assertions.assertEquals(
2,
finalNode.getCluster().getMembers().size()));
+ System.out.println(
Review Comment:
```suggestion
log.info(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
