EricJoy2048 commented on code in PR #5680:
URL: https://github.com/apache/seatunnel/pull/5680#discussion_r1368198390
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/BaseSourceConfig.java:
##########
@@ -40,8 +40,8 @@ public class BaseSourceConfig {
.noDefaultValue()
.withDescription("The file path of source files");
- public static final Option<String> DELIMITER =
- Options.key("delimiter")
+ public static final Option<String> FIELD_DELIMITER =
Review Comment:
Directly modifying parameter names can cause compatibility issues.
You can update option like this:
```
public static final Option<String> FIELD_DELIMITER =
Options.key("field_delimiter")
.stringType()
.defaultValue(TextFormatConstant.SEPARATOR[0])
.withFallbackKeys("delimiter")
.withDescription(
"The separator between columns in a row of data.
Only needed by `text` file format");
```
And then you need update the code at the point used this option.
```
String delimiter =
ReadonlyConfig.fromConfig(pluginConfig)
.get(BaseSourceConfig.FIELD_DELIMITER);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
