Hisoka-X commented on code in PR #5680:
URL: https://github.com/apache/seatunnel/pull/5680#discussion_r1374152939


##########
docs/en/connector-v2/source/FtpFile.md:
##########
@@ -221,9 +154,73 @@ connector will generate data as the following:
 |---------------|-----|--------|
 | tyrantlucifer | 26  | male   |
 
-### common options
+### delimiter/field_delimiter [string]
 
-Source plugin common parameters, please refer to [Source Common 
Options](common-options.md) for details.
+**delimiter** parameter will deprecate after version 2.3.5, please use 
**field_delimiter** instead.

Review Comment:
   ```suggestion
   **delimiter** parameter will deprecate after version 2.3.4, please use 
**field_delimiter** instead.
   ```



##########
docs/en/connector-v2/source/HdfsFile.md:
##########
@@ -55,9 +55,13 @@ Read data from hdfs file system.
 | kerberos_keytab_path      | string  | no       | -                   | The 
keytab path of kerberos                                                         
                                                                                
                                                                                
                                                                                
          |
 | skip_header_row_number    | long    | no       | 0                   | Skip 
the first few lines, but only for the txt and csv.For example, set like 
following:`skip_header_row_number = 2`.then Seatunnel will skip the first 2 
lines from source files                                                         
                                                                                
                     |
 | schema                    | config  | no       | -                   | the 
schema fields of upstream data                                                  
                                                                                
                                                                                
                                                                                
          |
-| common-options            |         | no       | -                   | 
Source plugin common parameters, please refer to [Source Common 
Options](common-options.md) for details.                                        
                                                                                
                                                                                
                              |
 | sheet_name                | string  | no       | -                   | 
Reader the sheet of the workbook,Only used when file_format is excel.           
                                                                                
                                                                                
                                                                                
              |
 | compress_codec            | string  | no       | none                | The 
compress codec of files                                                         
                                                                                
                                                                                
                                                                                
          |
+| common-options            |         | no       | -                   | 
Source plugin common parameters, please refer to [Source Common 
Options](common-options.md) for details.                                        
                                                                                
                                                                                
                              |
+
+### delimiter/field_delimiter [string]
+
+**delimiter** parameter will deprecate after version 2.3.5, please use 
**field_delimiter** instead.

Review Comment:
   ```suggestion
   **delimiter** parameter will deprecate after version 2.3.4, please use 
**field_delimiter** instead.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to