Hisoka-X commented on code in PR #5680: URL: https://github.com/apache/seatunnel/pull/5680#discussion_r1374157150
########## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-local-e2e/src/test/resources/excel/local_excel_projection_to_assert_with_delimiter.conf: ########## @@ -0,0 +1,104 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +env { + execution.parallelism = 1 + spark.app.name = "SeaTunnel" + spark.executor.instances = 2 + spark.executor.cores = 1 + spark.executor.memory = "1g" + spark.master = local + job.mode = "BATCH" +} + +source { + LocalFile { + path = "/seatunnel/read/excel" + result_table_name = "fake" + file_format_type = excel + delimiter = ; + read_columns = [c_string, c_boolean] + skip_header_row_number = 1 + schema = { + fields { + c_map = "map<string, string>" + c_array = "array<int>" + c_string = string + c_boolean = boolean + c_tinyint = tinyint + c_smallint = smallint + c_int = int + c_bigint = bigint + c_float = float + c_double = double + c_bytes = bytes + c_date = date + c_decimal = "decimal(38, 18)" + c_timestamp = timestamp + c_row = { + c_map = "map<string, string>" + c_array = "array<int>" + c_string = string + c_boolean = boolean + c_tinyint = tinyint + c_smallint = smallint + c_int = int + c_bigint = bigint + c_float = float + c_double = double + c_bytes = bytes + c_date = date + c_decimal = "decimal(38, 18)" + c_timestamp = timestamp + } + } + } + } +} + +sink { + Assert { + rules { + row_rules = [ + { + rule_type = MAX_ROW + rule_value = 5 + } + ], + field_rules = [ + { + field_name = c_string + field_type = string + field_value = [ + { + rule_type = NOT_NULL + } + ] + }, + { + field_name = c_boolean + field_type = boolean + field_value = [ + { + rule_type = NOT_NULL + } + ] + } + ] + } + } Review Comment: The test case seem like can not prove the delimiter is ":". Could you add a rule to check row value? You can refer https://github.com/apache/seatunnel/pull/5083/files#diff-a68b2797462655fd5ee139c5c129df223f4de9c25e72e41a6432012d00ede0a8 ########## docs/en/connector-v2/source/FtpFile.md: ########## @@ -221,9 +154,73 @@ connector will generate data as the following: |---------------|-----|--------| | tyrantlucifer | 26 | male | -### common options +### delimiter/field_delimiter [string] -Source plugin common parameters, please refer to [Source Common Options](common-options.md) for details. +**delimiter** parameter will deprecate after version 2.3.5, please use **field_delimiter** instead. Review Comment: ```suggestion **delimiter** parameter will deprecate after version 2.3.4, please use **field_delimiter** instead. ``` ########## docs/en/connector-v2/source/HdfsFile.md: ########## @@ -55,9 +55,13 @@ Read data from hdfs file system. | kerberos_keytab_path | string | no | - | The keytab path of kerberos | | skip_header_row_number | long | no | 0 | Skip the first few lines, but only for the txt and csv.For example, set like following:`skip_header_row_number = 2`.then Seatunnel will skip the first 2 lines from source files | | schema | config | no | - | the schema fields of upstream data | -| common-options | | no | - | Source plugin common parameters, please refer to [Source Common Options](common-options.md) for details. | | sheet_name | string | no | - | Reader the sheet of the workbook,Only used when file_format is excel. | | compress_codec | string | no | none | The compress codec of files | +| common-options | | no | - | Source plugin common parameters, please refer to [Source Common Options](common-options.md) for details. | + +### delimiter/field_delimiter [string] + +**delimiter** parameter will deprecate after version 2.3.5, please use **field_delimiter** instead. Review Comment: ```suggestion **delimiter** parameter will deprecate after version 2.3.4, please use **field_delimiter** instead. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
