Hisoka-X commented on code in PR #5985:
URL: https://github.com/apache/seatunnel/pull/5985#discussion_r1421974132
##########
seatunnel-translation/seatunnel-translation-spark/seatunnel-translation-spark-common/src/main/java/org/apache/seatunnel/translation/spark/serialization/InternalRowCollector.java:
##########
@@ -50,7 +48,7 @@ public InternalRowCollector(
this.rowSerialization = new InternalRowConverter(dataType);
this.collectTotalCount = new AtomicLong(0);
this.envOptions = (Map) envOptionsInfo;
- FlowControlStrategy flowControlStrategy =
getFlowControlStrategy(envOptions);
+ FlowControlStrategy flowControlStrategy =
FlowControlStrategy.fromMap(envOptions);
Review Comment:
After this changed, the `FlowControlStrategy` always be not null, so even
user not configure flow control, some method will be invoked in
https://github.com/apache/seatunnel/blob/d4a323efef3979c44cda20cc4b6c7b04b7454f5a/seatunnel-translation/seatunnel-translation-spark/seatunnel-translation-spark-common/src/main/java/org/apache/seatunnel/translation/spark/serialization/InternalRowCollector.java#L63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
