TyrantLucifer commented on code in PR #5985:
URL: https://github.com/apache/seatunnel/pull/5985#discussion_r1421975998
##########
seatunnel-translation/seatunnel-translation-spark/seatunnel-translation-spark-common/src/main/java/org/apache/seatunnel/translation/spark/serialization/InternalRowCollector.java:
##########
@@ -50,7 +48,7 @@ public InternalRowCollector(
this.rowSerialization = new InternalRowConverter(dataType);
this.collectTotalCount = new AtomicLong(0);
this.envOptions = (Map) envOptionsInfo;
- FlowControlStrategy flowControlStrategy =
getFlowControlStrategy(envOptions);
+ FlowControlStrategy flowControlStrategy =
FlowControlStrategy.fromMap(envOptions);
Review Comment:
I have a problem, why design this can be null and setting default value
(Integer.MAX_VALUE) in flow control strategy? If user dose not set these
values, How to reflect speed limit behavior? In the implementation of the three
engines, this is completely inconsistent. Where is the detailed STIP for this
feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
