TyrantLucifer commented on code in PR #5985:
URL: https://github.com/apache/seatunnel/pull/5985#discussion_r1421985880
##########
seatunnel-translation/seatunnel-translation-spark/seatunnel-translation-spark-common/src/main/java/org/apache/seatunnel/translation/spark/serialization/InternalRowCollector.java:
##########
@@ -50,7 +48,7 @@ public InternalRowCollector(
this.rowSerialization = new InternalRowConverter(dataType);
this.collectTotalCount = new AtomicLong(0);
this.envOptions = (Map) envOptionsInfo;
- FlowControlStrategy flowControlStrategy =
getFlowControlStrategy(envOptions);
+ FlowControlStrategy flowControlStrategy =
FlowControlStrategy.fromMap(envOptions);
Review Comment:
I think rate limit need a complete design document is needed to clearly
define the boundaries of the functionality. I will close this pull request and
open again after discussing and implementing the plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
