hawk9821 commented on code in PR #7835:
URL: https://github.com/apache/seatunnel/pull/7835#discussion_r1800278814
##########
seatunnel-connectors-v2/connector-paimon/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/sink/commit/PaimonAggregatedCommitter.java:
##########
@@ -99,8 +111,14 @@ public List<PaimonAggregatedCommitInfo> commit(
@Override
public PaimonAggregatedCommitInfo combine(List<PaimonCommitInfo>
commitInfos) {
- List<List<CommitMessage>> committables = new ArrayList<>();
- commitInfos.forEach(commitInfo ->
committables.add(commitInfo.getCommittables()));
+ Map<Long, List<CommitMessage>> committables = new HashMap<>();
+ commitInfos.forEach(
Review Comment:
suggest using stream api groupby
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
