Hisoka-X commented on code in PR #7835:
URL: https://github.com/apache/seatunnel/pull/7835#discussion_r1800335077
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/multitablesink/MultiTableSinkWriter.java:
##########
@@ -238,7 +245,14 @@ public Optional<MultiTableCommitInfo> prepareCommit()
throws IOException {
.entrySet()) {
Optional<?> commit;
try {
- commit =
sinkWriterEntry.getValue().prepareCommit();
+ SinkWriter<SeaTunnelRow, ?, ?>
sinkWriter =
Review Comment:
> I thought so at first, but there were so many writers to change
After update
https://github.com/apache/seatunnel/pull/7835#discussion_r1800327463, I think
the change should be less.
> Also schema evolution here (applySchemaChange(SchemaChangeEvent event))
also calls prepareCommit()
Looks like it is problem of JDBCWriter, not engine. The jdbc sink writer
does not care checkpointid when invoke `prepareCommit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
