Re: [PR] [Improve][Connector-v2] Use checkpointId as the commit's identifier instead of the hash for streaming write of paimon sink [seatunnel]

Mon, 14 Oct 2024 19:30:54 -0700 


dailai commented on code in PR #7835:
URL: https://github.com/apache/seatunnel/pull/7835#discussion_r1800330249


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/multitablesink/MultiTableSinkWriter.java:
##########
@@ -238,7 +245,14 @@ public Optional<MultiTableCommitInfo> prepareCommit() 
throws IOException {
                                                             .entrySet()) {
                                         Optional<?> commit;
                                         try {
-                                            commit = 
sinkWriterEntry.getValue().prepareCommit();
+                                            SinkWriter<SeaTunnelRow, ?, ?> 
sinkWriter =

Review Comment:
   I thought so at first, but there were so many writers to change, Also schema 
evolution here (applySchemaChange(SchemaChangeEvent event)) also calls 
prepareCommit() and has no way to pass checkpointId.
   
   ![截屏2024-10-15 10 29 
47](https://github.com/user-attachments/assets/8b89ad0f-6bf3-4353-a657-4c24b5a2753c)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to