CloverDew commented on code in PR #9576: URL: https://github.com/apache/seatunnel/pull/9576#discussion_r2583768321
########## seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/execution/AbstractSinkExecuteProcessor.java: ########## Review Comment: Why add an extra layer of abstraction on top of SinkExecuteProcessor? It seems unnecessary. ########## seatunnel-translation/seatunnel-translation-flink/seatunnel-translation-flink-20/src/main/java/org/apache/seatunnel/translation/flink/metric/FlinkJobMetricsSummary.java: ########## Review Comment: This class looks very similar to the existing implementation in the `org.apache.seatunnel.translation.flink.metric` package, except for a few new methods. It doesn't seem to require adapting to any new interface implementations, so it appears that methods can be added to the existing class without needing to rewrite it entirely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
