Re: [PR] [Feature][Flink] Add flink version 1.20.1 support [seatunnel]

[via GitHub]

yzeng1618 commented on PR #9576:
URL: https://github.com/apache/seatunnel/pull/9576#issuecomment-3650891583

   > > <img alt="8e64f74d721a21442b01547ff231e20f" width="2000" height="1330" 
src="https://private-user-images.githubusercontent.com/51053924/526278703-8f14f534-31fa-4eb3-a5c5-6016f68edb0f.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjU3MDkyNjMsIm5iZiI6MTc2NTcwODk2MywicGF0aCI6Ii81MTA1MzkyNC81MjYyNzg3MDMtOGYxNGY1MzQtMzFmYS00ZWIzLWE1YzUtNjAxNmY2OGVkYjBmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjE0VDEwNDI0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc0ZTZiNzM3MWM3YjYyN2QxNzkwYmMxYmIwZGNiOGRmNzRmNzY5ZWVjNGRjOGEyMDI0YjJmMzA4YTNhOTY0NzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.cekvPucpGWJA5lnb6bEyp_H-kzwAnrZzco1HTEJnrvA";>
   > > I try to implement metrics use origin logic, it looks worked.
   > > 
https://github.com/TyrantLucifer/incubator-seatunnel/tree/BDPL-support1.20.1-test-metrics
   > > cc @CloverDew
   > 
   > meter also worked
   > 
   > <img alt="image" width="1251" height="566" 
src="https://private-user-images.githubusercontent.com/51053924/526279189-033d827d-4916-4d53-8ded-ab1530c0e410.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjU3MTM1ODksIm5iZiI6MTc2NTcxMzI4OSwicGF0aCI6Ii81MTA1MzkyNC81MjYyNzkxODktMDMzZDgyN2QtNDkxNi00ZDUzLThkZWQtYWIxNTMwYzBlNDEwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjE0VDExNTQ0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM2NmIxNzQ1ZmIyYzhmODFlODk2MGZmM2E5ZTY2MjdiMDdmMmQwMGRjZTE0M2ViNTJmMjYyYWQ5N2I4OTQyMDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.o3JLW3G7ktzSb1WSTP2TYFkY5avPUz0Q9--MOaudzRo";>
   
   Thanks a lot for your review and guidance. @TyrantLucifer 
   My original counter implementation in the test branch was mainly to get 
things working, but it has some drawbacks: it maintains two states 
(metrics.Counter + accumulator), relies on special handling for a few “key” 
metrics, and diverges from the Flink 1.13 implementation.
   The current approach using runtimeContext.getLongCounter(name) and the 
shared FlinkCounter is cleaner and more consistent across Flink versions, so 
I’m happy to follow this design.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org