yzeng1618 commented on code in PR #9576: URL: https://github.com/apache/seatunnel/pull/9576#discussion_r2583828652
########## seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/execution/AbstractSinkExecuteProcessor.java: ########## Review Comment: Thanks for calling this out. My initial thought for introducing AbstractSinkExecuteProcessor was to pull out the common lifecycle and metric wiring so that future sink processors can be extended in a consistent way. Concretely, this base class centralizes the shared logic (building the DataStream pipeline, wiring metrics, and managing the execution lifecycle) and leaves only the version‑specific part (for example, how the DataStreamSink is created for Flink 1.20 using the new sinkTo(Sink) API instead of the v1 adapter) to the concrete implementation. This keeps the Flink‑version specific integration localized, avoids duplicating the same lifecycle/metric code across different processors, and should make it easier to support additional Flink versions or execution modes without changing the higher‑level SinkExecuteProcessor contract. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
