AshharAhmadKhan commented on PR #10432: URL: https://github.com/apache/seatunnel/pull/10432#issuecomment-3845471356
Hi @davidzollo, thanks for the detailed review. I’ve simplified the implementation per your guidance: - Fixed the type mismatch (now passes catalogTable.getSeaTunnelRowType()) - Removed the unused serializer cache - Removed the structural-only test - Updated documentation to reflect the shared-schema behavior The Socket connector now implements SupportMultiTableSink and SupportMultiTableSinkWriter correctly to prevent ClassCastException in multi-table scenarios, using a shared schema consistent with its debug-oriented use case. Ready for re-review. Let me know if you’d like any adjustments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
