AshharAhmadKhan commented on PR #10432: URL: https://github.com/apache/seatunnel/pull/10432#issuecomment-3885324698
Hi @davidzollo @corgy-w, I've rebased the PR on the latest `upstream/dev` and verified the implementation locally with Java 17. **Summary:** ✅ `SocketSink` implements `SupportMultiTableSink` ✅ `SocketSinkWriter` implements `SupportMultiTableSinkWriter<Void>` ✅ Uses `catalogTable.getSeaTunnelRowType()` (correct type) ✅ Added `SocketSinkWriterContractTest` (passes with Java 17) ✅ Documentation in `MULTI_TABLE_SINK.md` ✅ **Only 4 files changed** (Socket connector only) **About the local build failure:** The local build fails with Lombok + Java 21 incompatibility (my environment). This is unrelated to my Socket connector changes: - Error: `java.lang.NoSuchFieldError: 'com.sun.tools.javac.tree.JCTree com.sun.tools.javac.tree.JCTree$JCImport.getQualifiedIdentifier()'` - Cause: Project uses Lombok 1.18.24, which doesn't support Java 21 - Solution: Lombok 1.18.30+ needed for Java 21 **Local verification with Java 17:** ``` [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 [INFO] BUILD SUCCESS ``` Could you please trigger the Apache CI? It should pass as the CI environment uses Java 11/17. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
