AshharAhmadKhan commented on PR #10432: URL: https://github.com/apache/seatunnel/pull/10432#issuecomment-3863855644
Hi @corgy-w @davidzollo, I've cleaned up the branch with a single clean commit containing only Socket connector changes. All review feedback has been addressed: **Changes:** ✅ SocketSink implements `SupportMultiTableSink` ✅ SocketSinkWriter implements `SupportMultiTableSinkWriter<Void>` ✅ Uses `catalogTable.getSeaTunnelRowType()` (correct type) ✅ Removed unsafe serializer cache per review ✅ Added `SocketSinkWriterContractTest` to verify interface implementation ✅ Comprehensive JavaDoc and MULTI_TABLE_SINK.md documentation **Regarding the build failure:** The current build error appears to be a **Java/Lombok version incompatibility** in the project's build tooling (not related to my changes): ``` java.lang.NoSuchFieldError: Class com.sun.tools.javac.tree.JCTree$JCImport does not have member field 'com.sun.tools.javac.tree.JCTree qualid' ``` This error occurs in `SocketCommonOptions.java` (which I did not modify) and is a known issue when running with Java 21 locally. The Apache CI environment likely uses Java 11/17 and should not encounter this issue. **Could you please trigger the CI to verify?** Thank you for the detailed reviews and guidance! --- **Files changed in this PR:** - `seatunnel-connectors-v2/connector-socket/MULTI_TABLE_SINK.md` (new) - `seatunnel-connectors-v2/connector-socket/src/main/java/.../SocketSink.java` (modified) - `seatunnel-connectors-v2/connector-socket/src/main/java/.../SocketSinkWriter.java` (modified) - `seatunnel-connectors-v2/connector-socket/src/test/java/.../SocketSinkWriterContractTest.java` (new) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
