77amyfly opened a new pull request, #10965:
URL: https://github.com/apache/seatunnel/pull/10965

   ### Purpose of this pull request
   
   Fix #10547
   
   Fix NaN display in the job detail Overview table. The `sourceCell` and 
`sinkCell` functions use `tablePaths` to look up values in metrics, but the 
`tablePaths` format does not match the metrics keys returned by the backend. 
For example:
   - `tablePaths` returns: `["fake"]`
   - metrics key is: `"Source[0].fake"`
   
   This mismatch causes `Number(undefined)` to be evaluated as `NaN`. Fixed by 
using `endsWith` to match `tablePaths` against metrics keys instead of direct 
lookup.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. The job detail Overview table now correctly displays metrics values 
(Received Bytes, Write Bytes, Received Count, Write Count, etc.) instead of NaN 
when `tablePaths` does not match metrics keys.
   before fix:
   <img width="1166" height="647" alt="Screenshot 2026-05-27 at 12 35 00 PM" 
src="https://github.com/user-attachments/assets/7aecd3c8-a672-496d-a497-9b11f42d40a3";
 />
   after fix:
   <img width="1198" height="659" alt="Screenshot 2026-05-27 at 12 35 53 PM" 
src="https://github.com/user-attachments/assets/48cd3e26-b9d7-4300-b875-8a80b500885c";
 />
   
   
   ### How was this patch tested?
   
   1. Added unit test in `seatunnel-engine-ui/src/tests/detail.spec.ts` to 
verify that no NaN is displayed when `tablePaths` does not match metrics keys.
   2. All existing unit tests pass after the fix (6 test files, 12 tests 
passed).
   
   ### Check list
   * [ ] If any new Jar binary package adding in your PR, please add License 
Notice according [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new 
feature.
   * [ ] If necessary, please update `incompatible-changes.md` to describe the 
incompatibility caused by this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to