DanielLeens commented on PR #10965: URL: https://github.com/apache/seatunnel/pull/10965#issuecomment-4576360666
Thanks for taking a look here as well. On my side, the current blocker is still the same one from the latest Daniel review: on the current head `262278b65888f0da43900e2bdb86d8360f2ae928`, the `endsWith(path)` fallback can still attribute metrics to the wrong vertex when multiple sources or sinks share the same table path. Since there is still no new commit after that reviewable head, I am keeping this as a reply-only follow-up rather than starting another full re-review in this batch. Once a code update lands for that attribution path, please ping me again and I will recheck the new head from scratch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
