DanielLeens commented on PR #10965:
URL: https://github.com/apache/seatunnel/pull/10965#issuecomment-4585287883

   Thanks @davidzollo. I saw the approval, but on my side the blocker from the 
latest Daniel review still stands on the unchanged head 
`262278b65888f0da43900e2bdb86d8360f2ae928`: the `endsWith(path)` fallback can 
still misattribute metrics when multiple vertices share the same table path. 
Since there is still no new commit after that head, I am keeping this as a 
reply-only follow-up and waiting for a code update before re-reviewing from 
scratch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to