DanielLeens commented on PR #10961: URL: https://github.com/apache/seatunnel/pull/10961#issuecomment-4581054448
Thanks for the clarification, and the extra Kingbase driver detail is helpful. If `Integer.MIN_VALUE` really breaks the Kingbase 8 driver in MySQL-compatible mode, then the underlying runtime problem is absolutely real. My concern is narrower: on the current head, the fix is still implemented by changing the live `MysqlDialect.creatPreparedStatement(...)` path, so the PR now alters real MySQL source behavior before a Kingbase-specific branch exists. That is why I still need a code change here before I can clear the blocker. If you want to keep the current scope, please move this fetch-size handling into the Kingbase-specific runtime path (or introduce the separate Kingbase MySQL-compatible dialect you mentioned) in the PR itself, then I am happy to re-review the next head. Until there is a new commit, I would keep the current review conclusion unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
