DanielLeens commented on PR #10961: URL: https://github.com/apache/seatunnel/pull/10961#issuecomment-4586654132
Thanks for the detailed follow-up. I took another look at the current PR state, and the key point here is that the head is still `76c7c8524b86444261d75d2100209d0f0094b62c`, which is the same revision I already reviewed in the latest Daniel comment. So from my side this is still a reply-only follow-up on the unchanged head, not a fresh full re-review. If the MySQL-side change has really been removed from the effective PR code now, please push the follow-up commit (or point to the exact new commit once it lands) and I will gladly re-review that new head from scratch. On the current unchanged revision, the existing Daniel blocker remains the same: I still need the Kingbase-specific fix to stay isolated from the live `MysqlDialect` runtime path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
