goutamadwant commented on PR #11171: URL: https://github.com/apache/seatunnel/pull/11171#issuecomment-4829254095
Hi @DanielLeens @davidzollo I updated the PR based on the review. Oracle SCN startup now keeps the SCN as a structured specific offset through `StartupConfig.specificOffset(Map)`, so it uses `RedoLogOffsetFactory.specific(Map)`. The existing file/position specific offset path is unchanged. I also added a focused check that Oracle CDC only exposes `StopMode.NEVER`. Verified with: ```shell ./mvnw -q -pl seatunnel-connectors-v2/connector-cdc/connector-cdc-base,seatunnel-connectors-v2/connector-cdc/connector-cdc-oracle -Dtest=OracleIncrementalSourceFactoryTest -DfailIfNoTests=false -DskipITs test ./mvnw -q -pl seatunnel-connectors-v2/connector-cdc/connector-cdc-base,seatunnel-connectors-v2/connector-cdc/connector-cdc-oracle -DskipTests -DskipITs package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
