hllqkb commented on PR #11340:
URL: https://github.com/apache/seatunnel/pull/11340#issuecomment-4889599659
Thanks for the detailed review. Here's what I've fixed:
**Blocking items:**
1. **Schema consistency fix** — Updated `HugeGraphSourceReader.mapVertex()`
and `mapEdge()` to convert emitted values to match the inferred schema:
- `vertex.id()` (returns `Object`) → `String.valueOf()` to match inferred
`STRING_TYPE`
- `edge.sourceId()` / `edge.targetId()` (return `Object`) →
`String.valueOf()`
- Property values with `Date` type → converted to `LocalDate` to match
`LOCAL_DATE_TYPE`
- Property values with `Collection` type → converted to `Object[]` to
match `ArrayType`
2. **Cardinality-aware schema inference** — Added `inferPropertyType()` in
`HugeGraphSourceFactory` that checks `PropertyKey.cardinality()`:
- `SINGLE` → scalar type (unchanged behavior)
- `LIST` / `SET` → `ArrayType.of(baseType)` (e.g., `ARRAY<STRING>`,
`ARRAY<INT>`)
**Non-blocking (not yet addressed):**
- Reader tests remain `@Disabled` as they require a running HugeGraph
instance. Happy to rework them as a follow-up.
Branch has been rebased on latest upstream `dev` and pushed. CI should
trigger automatically on the updated head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
