hllqkb commented on PR #11340: URL: https://github.com/apache/seatunnel/pull/11340#issuecomment-4894479175
Thanks for the detailed review. A few updates on this: ### d2f9c06dc — edge.id normalization fix Following your earlier review, I identified and fixed one remaining schema/runtime mismatch: `mapEdge()` was writing `edge.id()` directly without `String.valueOf()`, while `mapVertex()` and `source_id`/`target_id` already normalized to String. - `HugeGraphSourceReader.java:214` — `fields[i] = edge.id()` → `fields[i] = String.valueOf(edge.id())` - Fixed incorrect assertion in `testReadEdges_withPropertyFilter` (target_id is a structural field, not filtered by selectedProperties) - Unit tests: 29 passed, 0 failed ### Sync status I am aware this branch is behind dev. I will sync and rebase once the current CI signals are green to avoid noisy intermediate pushes. ### CI The workflow run detection failure is a known issue with forks. The existing commits on this PR have been verified locally: - Spotless: PASS - Unit tests: 29 passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
