hllqkb commented on PR #11340:
URL: https://github.com/apache/seatunnel/pull/11340#issuecomment-4951272736
Hi @SEZ9, thanks for the thorough review. I've addressed all 9 items in the
latest commit `231c4d059`:
**Issue 1 (Blocking - credential leak)**
- Replaced Lombok `@Data` with `@Getter` + `@Setter` + `@ToString` on
`HugeGraphSourceConfig`
- Added `@ToString.Exclude` on the `password` field so it is masked in any
log or exception output
**Issue 2 (missing docs)**
- Added `docs/en/connector-v2/source/HugeGraph.md` with Key Features,
Options table, Data Type Mapping, Schema Inference Rules, Usage Examples
(inferred schema, user-defined schema, HTTPS), and Changelog
- Added `docs/zh/connector-v2/source/HugeGraph.md` as the Chinese translation
**Issue 3 (iterateVertices/iterateEdges bypass retry)**
- Added an inner `RetryIterator<T>` in `HugeGraphClient` that wraps the raw
client iterator
- `hasNext()` and `next()` are now protected by the same retry/reconnect
loop used by the sink path: catches `ServerException` / `ClientException`,
triggers `reconnect()`, sleeps `retryBackoffMs`, and rethrows as
`HugeGraphConnectorException(READ_FAILED)` after max retries
**Issue 4 (hardcoded http://)**
- Added `protocol` option in `HugeGraphOptions` (default `http`, optional
`https`)
- `createClient()` now builds the URL as `%s://%s:%d` using the configured
protocol
- When `protocol = https`, the builder calls `configSSL(null, null)`
**Issue 5 (offset parameter ignored)**
- Removed the unused `listVertices(String label, int offset, int limit)` and
`listEdges(String label, int offset, int limit)` methods from
`HugeGraphClient`. The source reader only uses `iterateVertices` /
`iterateEdges`.
**Issue 6 (graph_space silently ignored)**
- `createClient()` now calls `builder.configGraph(graphSpace)` when
`graphSpace` is non-empty, passing the configured graph space to the HugeClient
builder
**Issue 7 (no validation of page_size/limit)**
- `HugeGraphSourceConfig.of()` now validates `pageSize > 0` and `limit > 0`
(when present), throwing `HugeGraphConnectorException(ILLEGAL_CONFIG_ARGUMENT)`
with a clear message for fast feedback at job submission time
**Issue 8 (@Deprecated missing Javadoc)**
- Added Javadoc to the deprecated constructor: `/** @deprecated use {@link
#HugeGraphClient(String, int, String, String, String, String, int, long,
String)} instead. */`
**Issue 9 (plugin-mapping entry position)**
- Moved `seatunnel.source.HugeGraph = connector-hugegraph` from the sink
block to the source block, right before `seatunnel.sink.HugeGraph`
All unit tests pass (29 tests, 0 failures). Spotless formatting and
compilation verified locally.
cc @DanielLeens for re-review when convenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
