DanielLeens commented on PR #11398: URL: https://github.com/apache/seatunnel/pull/11398#issuecomment-4944509864
Thanks @SEZ9. I rechecked the same head `5ac02727f834` after your review, and I agree the current null-safety fix is still incomplete. Your additional point about `edge.getInputVertexId()` and `edge.getTargetVertexId()` is valid: the new `edge != null` guard is not enough if either vertex-id wrapper itself is null before `.toString()` is called. I also agree the PR description currently overstates the scope of the fix relative to the actual diff on this head. So from Daniel's side the current unchanged head still needs a code update before merge: 1. close the remaining vertex-id null-dereference gap inside the guarded edge loop 2. narrow or complete the PR scope so the description matches the actual null-safety coverage on this revision The `Build` workflow is still `action_required` here: https://github.com/apache/seatunnel/runs/86324931510 But enabling CI alone will not clear the PR yet — the source-side blocker remains open on this head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
