DanielLeens commented on PR #11337:
URL: https://github.com/apache/seatunnel/pull/11337#issuecomment-4944509808
Thanks @SEZ9. I rechecked the same head `b9f53b50b0a1` again after your
review.
I agree that the unrelated `FileMapStore.java` and `FileMapStoreTest.java`
engine-server changes should not stay bundled in this connector PR. Those files
are outside the PythonSource connector path and should be split into a
dedicated Zeta PR instead of landing under a `Connector-V2` review thread.
My earlier Python reader lifecycle blocker also still stands on this
unchanged head:
```text
PythonSourceReader.internalPollNext(...)
-> stdoutReader.readLine() loop
-> only returns after stdout reaches EOF
-> waitForProcessExit()
```
So a long-running or non-terminating script can still keep the source task
blocked in the main poll path until the child process exits.
So from Daniel's side the current head still needs a code update before
merge:
1. split the unrelated engine-server files into a separate PR
2. close the indefinite-blocking gap in
`PythonSourceReader.internalPollNext(...)`
The green Build is helpful, but it is not the remaining gate yet on this
revision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
