DanielLeens commented on PR #11307:
URL: https://github.com/apache/seatunnel/pull/11307#issuecomment-4968399586

   I share the same concern here.
   
   On the current head the switch to `Encoders.row(...)` makes the runtime 
effectively Spark 3.5+ only, so merging this as a transparent replacement for 
the existing Spark 3 line would drop Spark 3.3/3.4 compatibility for current 
users.
   
   The lowest-risk shape would be either:
   1. keep the current Spark 3.3 line and add a separate Spark 3.5 track / 
artifact path, or
   2. make the compatibility break explicit with fail-fast checks plus 
`incompatible-changes.md` documentation if the project intentionally wants to 
raise the minimum Spark 3 baseline.
   
   So from Daniel's side I would not merge the current revision as-is while 
that compatibility question is still open.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to