liunaijie commented on PR #11307: URL: https://github.com/apache/seatunnel/pull/11307#issuecomment-4977454490
> Thanks @liunaijie @DanielLeens I agree the current PR still replaces the existing Spark 3.3 build and runtime track even though the encoder shim avoids the immediate NoSuchMethodError > > I plan to rework this so the current Spark 3.3 starter translation module and E2E container remain unchanged and Spark 3.5.8 is added as a separate starter and validation track > > Proposed structure is: > > * keep seatunnel-spark-3-starter and seatunnel-translation-spark-3.3 on Spark 3.3 > * add seatunnel-spark-3.5-starter > * add a Spark 3.5 translation module only for APIs that cannot be shared safely > * keep both SPARK_3_3 and SPARK_3_5 E2E containers > * package and document both runtime options separately > > Does this module and artifact layout match what you have in mind before I rework the PR. Let me know. thanks! Sounds perfect! This layout is exactly what I expected, you can proceed to refactor the PR according to this structure directly.Thanks for your great work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
