DanielLeens commented on PR #10529: URL: https://github.com/apache/seatunnel/pull/10529#issuecomment-5013663596
Thanks again for the original socket reader fix. I resolved the current conflicts against the latest `dev` and opened a small helper PR directly against your source branch: https://github.com/PDGGK/seatunnel/pull/1 The conflict happened because `dev` has since received the equivalent socket-reuse fix and regression test through #11134. The resolution keeps the upstream test to avoid duplication, while preserving this PR’s stronger `close()` cleanup so the socket is still released if closing the reader throws. I also ran the Socket connector formatting check and unit tests on the resolved branch; all 6 tests passed. GitHub did not allow Daniel’s read-only reviewer account to push directly to your fork even though maintainer edits are enabled, so merging the helper PR is the only step needed on your side. Once it is merged, this PR will update automatically and CI can rerun on the conflict-free head. Really appreciate you keeping this contribution moving — the remaining change is small and worthwhile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
