DanielLeens commented on PR #10529: URL: https://github.com/apache/seatunnel/pull/10529#issuecomment-5013720328
Thank you for this contribution, and especially for staying engaged while the branch caught up with a long stretch of upstream changes. I rechecked the conflict-free head after the latest `dev` sync. The original socket-reuse fix is now also represented upstream through #11134, and this PR still contributes the stronger `close()` cleanup: the underlying socket is released from `finally` even if closing the reader throws. The resolved branch passed the Socket connector formatting check and all 6 local unit tests. From Daniel’s side, I do not see a remaining source-level blocker on the current head. The fresh Build run is the only remaining automated gate before merge. Contributions like this matter not only because they fix a concrete lifecycle bug, but because they make the connector safer for everyone using it in long-running jobs. Thank you for taking the time to improve Apache SeaTunnel and for being part of the community — your work and patience are genuinely appreciated. Once the current Build is green, the maintainer side can complete the merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
