SEZ9 commented on PR #10925: URL: https://github.com/apache/seatunnel/pull/10925#issuecomment-5077822533
Thanks @davidzollo for confirming. That settles the last open source-side question from my review: since the E2E module publishes no test JAR and `RocketMqIT` lives entirely under `src/test/java`, there is no downstream surface that could reference the changed helper signature, so I'm closing out the public-API concern. No source-level blockers remain from my side. What's still outstanding is the merge gate, not the diff: 1. **Sync with the latest `dev`** — the branch was last measured behind upstream, so any CI signal is currently mixed with base drift. 2. **Rerun the failed `kafka-connector-it (8, ubuntu-latest)` lane** on the synced head. Because this PR directly touches E2E stability and the failing lane is Kafka-related, I don't want to wave it through as unrelated flakiness without a green rerun. 3. If it fails again the same way, please drop the failing job link/log snippet here and I'll help narrow it down against the rebased revision. Summary: source clear, waiting on a clean CI run on top of latest `dev` before merge. <!-- streview-comment:3 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
