zhangshenghang commented on code in PR #10925:
URL: https://github.com/apache/seatunnel/pull/10925#discussion_r3675130089
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-sftp-e2e/src/test/java/org/apache/seatunnel/e2e/connector/file/fstp/SftpFileIT.java:
##########
@@ -125,27 +125,6 @@ public void startUp() throws Exception {
"/text/e2e.txt",
"/home/seatunnel/tmp/seatunnel/read/wildcard/e2e.txt",
sftpContainer);
-
- ContainerUtil.copyFileIntoContainers(
- "/text/e2e.txt",
- "/home/seatunnel/tmp/seatunnel/read/recursive/e2e.txt",
- sftpContainer);
-
- ContainerUtil.copyFileIntoContainers(
- "/text/e2e.txt",
- "/home/seatunnel/tmp/seatunnel/read/recursive/subdir/e2e.txt",
- sftpContainer);
-
- ContainerUtil.copyFileIntoContainers(
- "/text/e2e.txt",
-
"/home/seatunnel/tmp/seatunnel/read/recursive/subdir/deeper/e2e.txt",
- sftpContainer);
-
- ContainerUtil.copyFileIntoContainers(
- "/text/e2e.txt",
-
"/home/seatunnel/tmp/seatunnel/read/recursive/subdir/deeper/final/e2e.txt",
- sftpContainer);
-
Container.ExecResult chownResult =
Review Comment:
**P3 — Dead config files left behind after recursive setup cleanup**
The deleted SFTP `startUp` code (this region of the file) used to copy files
into `/home/seatunnel/tmp/seatunnel/read/recursive/...`. After this PR the
setup is gone, but these configs still exist and still reference the recursive
path:
-
`seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-sftp-e2e/src/test/resources/text/sftp_file_text_recursive_to_assert.conf`
(line 36: `path = "tmp/seatunnel/read/recursive"`)
-
`seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-sftp-e2e/src/test/resources/text/sftp_file_text_non_recursive_to_assert.conf`
(line 36)
I confirmed no Java test currently invokes them, so this is dead code.
Recommend deleting these two `.conf` files in the same PR to avoid future
confusion (someone will copy them as a template and get an empty source).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
