zhangshenghang commented on code in PR #10925:
URL: https://github.com/apache/seatunnel/pull/10925#discussion_r3675125977
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/cdc/mysql/MysqlCDCWithFlinkSchemaChangeIT.java:
##########
@@ -68,7 +68,7 @@ public class MysqlCDCWithFlinkSchemaChangeIT extends
TestSuiteBase implements Te
* Flink schema evolution can restart after XA recover/rollback on loaded
CI runners, so these
* assertions need enough time for the job to recover and replay the
schema-change event.
*/
- private static final long SCHEMA_EVOLUTION_ASSERT_TIMEOUT_MILLIS =
300_000L;
+ private static final long SCHEMA_EVOLUTION_ASSERT_TIMEOUT_MILLIS =
600_000L;
Review Comment:
**P3 — `SCHEMA_EVOLUTION_ASSERT_TIMEOUT_MILLIS = 600_000L`**
Bumping this from 5min to 10min masks Flink XA recovery/rollback slowness.
Long timeouts are a band-aid; if the schema-evolution-after-XA-recover path is
the real issue, consider adding a metric or a smaller dedicated test that
catches the regression at, e.g., 2min. Otherwise a future change could silently
double the recovery time without anyone noticing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
