li3zhi4 commented on PR #11618: URL: https://github.com/apache/seatunnel/pull/11618#issuecomment-5157574289
Hi @SEZ9, per your request I've added an e2e test covering the `stop.mode="specific"` termination behavior: **New: `MysqlCDCStopModeSpecificIT`** (commit `de40a3d6f0`) - Starts a MySQL CDC job with `startup.mode=specific` + `stop.mode=specific` (new conf `mysqlcdc_stop_mode_specific.conf`) - Records the current binlog offset as the stop offset, writes rows before and after it - Asserts the job **terminates on its own (FINISHED)** at the configured stop offset instead of running forever (`jobFuture.get(120s)` with exit code 0) - Verifies only the rows written before the stop offset are synced (rows after are not) Also, regarding your note to check other CDC connectors sharing this fetch-task pattern: the same `FetchTask`-based bounded-read issue applies to any CDC source whose `MySqlBinlogFetchTask`-equivalent creates a plain streaming source without a stop check. This PR fixes the MySQL path; Oracle/SqlServer/Postgres only support `stop.mode=never` in their option rules today, so they cannot hit the combination. I can file a follow-up issue to audit the other connectors if the community wants. Verification: `spotless:check` passes; the new test class compiles. I could not run the e2e locally (no Docker in this environment), so it will be exercised by the CI e2e job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
