SEZ9 commented on PR #11618: URL: https://github.com/apache/seatunnel/pull/11618#issuecomment-5225134635
Thanks @li3zhi4 for the quick turnaround! 👍 The new `MysqlCDCStopModeSpecificIT` looks like a solid coverage approach — asserting the job reaches FINISHED at the recorded stop offset and verifying only pre-offset rows are synced is exactly the behavior we want to lock in. A few remaining items: 1. **CI verification**: Since you couldn't run the e2e locally, let's wait for the CI e2e job to pass before merging. Please keep an eye on the run and ping me if anything flaky shows up. 2. **Follow-up issue**: Yes, please do file a follow-up issue to audit the other `FetchTask`-based CDC connectors. Even though Oracle/SqlServer/Postgres only expose `stop.mode=never` in their option rules today, having the audit tracked will help whoever extends stop-mode support there later. Feel free to reference this PR in the issue. 3. Minor ask: could you double-check the 120s timeout in `jobFuture.get(120s)` is generous enough for the CI environment? Our CI runners can be slower than local machines, and we've seen CDC e2e tests need extra headroom for container startup + binlog replication. Otherwise this looks good to me. Once CI is green and the follow-up issue is filed, I'm happy to move forward. <!-- streview-comment:84 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
