li3zhi4 commented on PR #11618: URL: https://github.com/apache/seatunnel/pull/11618#issuecomment-5163736493
Hi @DanielLeens, I've addressed both non-blocking suggestions from your re-review (commit `dec6fecc3e`): **Suggestion A — regression coverage for `startup.mode = timestamp + stop.mode = specific`:** - New e2e `MysqlCDCStopModeSpecificIT.testMysqlCdcStopModeSpecificWithTimestampStartup` (new conf `mysqlcdc_stop_mode_specific_timestamp.conf`) - Asserts: rows written before the startup timestamp are **not** synced, rows between the startup timestamp and the stop offset **are** synced, rows after the stop offset are **not** synced, and the job **terminates (FINISHED)** at the configured stop offset - Locally verified: `Tests run: 2, Failures: 0, Errors: 0` (both `specific+specific` and `timestamp+specific` methods pass) **Suggestion B — bounded-read docs example:** - Added a "Bounded Read: Stop at a Specific Binlog Offset" section to both `docs/en/connectors/source/MySQL-CDC.md` and `docs/zh/connectors/source/MySQL-CDC.md`, with examples for `stop.mode=specific` alone and combined with `startup.mode=timestamp` Full local verification for this head: `spotless:check` ✅, `IncrementalSourceStreamFetcherTest` 2/2 ✅, `MysqlCDCStopModeSpecificIT` 2/2 ✅, compile ✅. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
