li3zhi4 commented on PR #11633:
URL: https://github.com/apache/seatunnel/pull/11633#issuecomment-5167773771
Thanks for the detailed review, @DanielLeens.
**Problem 1 (branch stacked on unrelated commits):** I double-checked the PR
diff. The PR contains only the 3 JSON default-value commits (`ef4d74d6e7`,
`f79f0bbcdf`, `9f73bd4954`) — 5 files, all in
`seatunnel-formats/seatunnel-format-json` and the Kafka e2e. `6bf786bee7` and
`ac8306f332` are part of the base branch (`apache/seatunnel:dev`) history, so
they do not appear in this PR's diff (verified via `git log upstream/dev..HEAD`
→ exactly the 3 JSON commits, and via the PR compare API → 3 commits / 5
files). No unrelated schema-evolution or file-reader changes ride along in this
PR.
**Problem 2 (missing docs):** Added EN/ZH documentation on the Schema
Feature page (`docs/{en,zh}/introduction/concepts/schema-feature.md`)
explaining how `schema.columns[].defaultValue` is applied when a JSON-formatted
message omits a field or sends an explicit `null`: the configured default is
applied and normalized to the column type by the deserializer; a present field
keeps its real value; unconfigured defaults keep the previous `null` behavior
(backward compatible). New commit `0028b78207`.
The head is now `0028b78207` (3 code commits + 1 docs commit, all JSON
default-value related).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
