li3zhi4 commented on PR #11633: URL: https://github.com/apache/seatunnel/pull/11633#issuecomment-5173757293
Thanks @DanielLeens — issue #11632 is now assigned and the acceptance checks you listed are all covered by tests in this PR: 1. **Missing field -> configured default value**: `JsonDefaultValueTest#testDefaultValueWhenFieldMissing` (field omitted), plus `testDefaultValueWithStringType`, `testDefaultValueWithMoreNumericAndPrimitiveTypes`, `testDefaultValueWithDateAndTimestampTypes`, `testDefaultValueWithDoubleNumberFormats`. 2. **Explicit JSON `null` -> configured default value**: `JsonDefaultValueTest#testDefaultValueWhenFieldMissing` (explicit `null` case) and the Kafka e2e message 2 (`KafkaJsonDefaultValueIT`, all fields explicitly `null`). 3. **No configured default -> existing `null` behavior preserved**: `JsonDefaultValueTest#testNoDefaultValueWhenFieldMissing`. 4. **No regression for `failOnMissingField` / parse-error handling**: existing `JsonRowDataSerDeSchemaTest` suites `testDeserializationMissingField`, `testDeserializationPassMissingField`, `testDeserializationIgnoreParseError`, `testDeserializationFailOnMissingFieldIgnoreParseError`, `testDeserializationNoJson` all still pass; the full `seatunnel-format-json` module runs 49/49 green with the new head `0028b78207`. Note: the head was pushed after your review (docs commit `0028b78207`), which reset the review state to REVIEW_REQUIRED; the diff still contains only the JSON default-value work (4 commits, 7 files). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
